Skip to content

Fix some DeprecationWarning#430

Merged
martinRenou merged 1 commit into
jupyter-widgets:masterfrom
xoolive:pr-fix_depwarn
Oct 8, 2019
Merged

Fix some DeprecationWarning#430
martinRenou merged 1 commit into
jupyter-widgets:masterfrom
xoolive:pr-fix_depwarn

Conversation

@xoolive

@xoolive xoolive commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

Following discussion #414 (comment)

There is still one DeprecationWarning to fix in traittypes.Dataset (dtype should be set in a tag() method)

@martinRenou

Copy link
Copy Markdown
Member

Concerning the Dataset trait, I wonder if you could not simply remove the dtype tag, it's set to its default value (None) anyway.

@martinRenou

Copy link
Copy Markdown
Member

Thanks a lot for the PR !!

@xoolive

xoolive commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

I think it should be enough to remove it but in the traittypes package

@martinRenou

Copy link
Copy Markdown
Member

I think it should be enough to remove it but in the traittypes package

Well, dtype seems to be used in the traittypes package, only we set it to None because I guess we don't want to force the user to use a specific dtype. I suppose removing it from ipyleaflet is just fine.

@xoolive

xoolive commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

Well, I can't say: maybe it's fine, but it doesn't fix the warning 😞

@martinRenou

Copy link
Copy Markdown
Member

I don't have those warnings... Which traitlets version are you using?

@xoolive

xoolive commented Oct 7, 2019

Copy link
Copy Markdown
Contributor Author

traitlets==4.3.2

But I don't get the warnings on a regular import, only when imported through an entry point:

# something along
for entry_point in pkg_resources.iter_entry_points("personal.stuff"):
    entry_point.load()

@martinRenou

Copy link
Copy Markdown
Member

I can merge this one as it is right now as it fixes some more warnings.

Thanks a lot for this PR! :)
I'll investigate concerning this Dataset thing

@martinRenou martinRenou merged commit 1853a62 into jupyter-widgets:master Oct 8, 2019
@xoolive

xoolive commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Thanks, about the extra warning, see jupyter-widgets/traittypes#41

@martinRenou

Copy link
Copy Markdown
Member

Good!! :) Thanks very much

@xoolive xoolive deleted the pr-fix_depwarn branch October 9, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants